fix(debugging): Prefer explicit attach pid over default bundle ID#411
Merged
Merged
Conversation
Drop inherited bundleId values when debug_attach_sim is called with an explicit pid so session defaults do not trip mutual-exclusion validation. Keep explicit bundleId plus explicit pid rejected and cover tool-local exclusive keys in the session-aware merge path. Fixes #410 Co-Authored-By: OpenAI Codex <noreply@openai.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
debug_attach_simattaching by PID whenbundleIdis configured in session defaults.Previously, session defaults were merged before validation, so a call with an explicit
pidinherited the defaultbundleIdand failed the tool's mutual-exclusion rule. This changes the shared session-aware merge typing so exclusive pairs can include tool-local keys likepid, then registersbundleId/pidfordebug_attach_simso explicit attach intent wins over inherited defaults.The explicit-invalid case remains rejected: callers still cannot pass both
bundleIdandpidin the same request.Fixes #410